Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid parsing of legacy query strings #815

Closed
bart-degreed opened this issue Sep 2, 2020 · 0 comments · Fixed by #825
Closed

Invalid parsing of legacy query strings #815

bart-degreed opened this issue Sep 2, 2020 · 0 comments · Fixed by #825
Assignees
Labels

Comments

@bart-degreed
Copy link
Contributor

In earlier versions, JADNC allowed the next query string:

?filter[title]=like:First,like:Second

which would only match titles containing both words "First" and "Second". We then took a breaking change to compose multiple filters using OR instead of AND for json:api compliance. Taking that into account, using the new syntax this is equivalent to:

?filter=expr:or(contains(title,'First'),contains(title,'Second'))

The bugs is that when legacy query string syntax is enabled, the parser fails to convert this correctly. It does not raise an error, but produces:

?filter=contains(title,'First,like:Second')

which is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

1 participant