Remove dependency on EF Core "Issue26779" AppContext switch #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…needs the Issue26779 EF Core back-compat switch. The switch is unavailable in EF 7, so this change unblocks us from upgrade.
Codecov Report
@@ Coverage Diff @@
## master #1176 +/- ##
=======================================
Coverage 92.58% 92.59%
=======================================
Files 241 241
Lines 7700 7709 +9
=======================================
+ Hits 7129 7138 +9
Misses 571 571
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
maurei
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EF Core v6.0.2 introduced a breaking change regarding change tracking of many-to-many relationships, which broke removing from many-to-many relationships in JsonApiDotNetCore in some cases. Fortunately, an AppContext switch to revert to the old behavior was added, which we've used since JsonApiDotNetCore v5.0.0.
The switch has been removed in EF (Core) 7. This PR fixes our code to no longer require the "Microsoft.EntityFrameworkCore.Issue26779" backward-compatibility switch. This unblocks us from upgrading to the latest preview version.
QUALITY CHECKLIST