Multi-target Annotations against .NET Standard 1.0 #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkoelman
force-pushed
the
multi-target-annotations
branch
from
e621ce1
to
8c3912f
Compare
bkoelman
force-pushed
the
multi-target-annotations
branch
from
8c3912f
to
205f00f
Compare
|
/cc @bjornharrtell we discussed this a while ago |
Codecov Report
@@ Coverage Diff @@
## master #1192 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 242 242
Lines 7706 7706
=======================================
Hits 7135 7135
Misses 571 571
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
4 tasks
bkoelman
force-pushed
the
multi-target-annotations
branch
from
205f00f
to
70c06b9
Compare
ThomasBarnekow
approved these changes
Oct 3, 2022
|
@ThomasBarnekow Thanks! |
maurei
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds netstandard1.0 as a TFM to the
JsonApiDotNetCore.AnnotationsNuGet package. This enables consumers to share their models project with .NET Framework code.The types in the NetStandard target don't actually work with JsonApiDotNetCore. This is provided solely for convenience so that consumers don't need to use conditional defines that are based on the target framework.
Internally, we use project-level conditionals to include/exclude source files per target framework, based on their file name:
*.shared.cs: Included for both targets*.netstandard.cs: Only included for netstandard1.0 (added asNonefor .NET 6 so it shows up in the IDE)*.cs: Only included for .NET 6This approach avoids the use of
#if ... #else ... #endifin our source files, which is problematic for Resharper CleanupCode.Closes #1190.
QUALITY CHECKLIST