Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: incorrect meta:total on secondary endpoint with filter #1259

Merged
merged 2 commits into from Feb 16, 2023
Merged

Fixed: incorrect meta:total on secondary endpoint with filter #1259

merged 2 commits into from Feb 16, 2023

Conversation

bart-vmware
Copy link
Contributor

Fixed: on secondary endpoint, the incoming filter from query string was not applied when determining total resource count via inverse relationship.

QUALITY CHECKLIST

…as not applied when determining total resource count via inverse relationship
@bkoelman bkoelman marked this pull request as ready for review February 16, 2023 13:08
@bkoelman bkoelman self-requested a review February 16, 2023 13:08
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #1259 (77f4869) into master (0adebfd) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 77f4869 differs from pull request most recent head a2c50e4. Consider uploading reports for the commit a2c50e4 to get more accurate results

@@            Coverage Diff             @@
##           master    #1259      +/-   ##
==========================================
- Coverage   92.69%   92.69%   -0.01%     
==========================================
  Files         243      243              
  Lines        7815     7814       -1     
==========================================
- Hits         7244     7243       -1     
  Misses        571      571              
Impacted Files Coverage Δ
...iDotNetCore/Queries/Internal/QueryLayerComposer.cs 99.63% <100.00%> (+0.36%) ⬆️
...ueries/Expressions/ResourceFieldChainExpression.cs 95.45% <0.00%> (-4.55%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bkoelman bkoelman merged commit 56cfe08 into json-api-dotnet:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants