Remove building an intermediate service provider at startup #1431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes building an intermediate service provider at startup, which is considered an anti-pattern, leading to occasional compatibility issues.
This unblocks use in Aspire (more specifically, its usage of
AddNpgsqlDataSource
, which throws anObjectDisposedException
) and fixes #1082.While
AddNpgsqlDataSource
(from theNpgsql.DependencyInjection
NuGet package) works in a regular API project, it fails in our integration tests (tracked at npgsql/efcore.pg#2542 (comment)).QUALITY CHECKLIST