Skip to content

Remove unused import && add return value #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 6, 2017
Merged

Remove unused import && add return value #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d92f46b
Merge pull request #1 from json-api-php/master
kefzce Oct 6, 2017
ff60c65
remove unused import
kefzce Oct 6, 2017
d547126
add return value
kefzce Oct 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Document.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,21 +74,21 @@ public static function fromResources(ResourceObject ...$resources): self
return $doc;
}

public static function fromIdentifier(ResourceIdentifier $identifier)
public static function fromIdentifier(ResourceIdentifier $identifier): self
{
$doc = new self;
$doc->data = new SingleIdentifierData($identifier);
return $doc;
}

public static function fromIdentifiers(ResourceIdentifier... $identifiers)
public static function fromIdentifiers(ResourceIdentifier... $identifiers): self
{
$doc = new self;
$doc->data = new MultiIdentifierData(...$identifiers);
return $doc;
}

public static function nullDocument()
public static function nullDocument(): self
{
$doc = new self;
$doc->data = new NullData();
Expand Down
1 change: 0 additions & 1 deletion test/Document/CompoundDocumentTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
namespace JsonApiPhp\JsonApi\Test\Document;

use JsonApiPhp\JsonApi\Document;
use JsonApiPhp\JsonApi\Document\Link\Link;
use JsonApiPhp\JsonApi\Document\Meta;
use JsonApiPhp\JsonApi\Document\Resource\Linkage\MultiLinkage;
use JsonApiPhp\JsonApi\Document\Resource\Linkage\SingleLinkage;
Expand Down