Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCC 7 reports various -Wimplicit-fallthrough= errors #309

Closed
marxin opened this issue Mar 20, 2017 · 1 comment
Closed

GCC 7 reports various -Wimplicit-fallthrough= errors #309

marxin opened this issue Mar 20, 2017 · 1 comment

Comments

@marxin
Copy link

marxin commented Mar 20, 2017

GCC properly reports various places in code, where a case label falls through to another label:

json_object.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
json_tokener.c:339:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
linkhash.c:418:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
linkhash.c:419:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
linkhash.c:420:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
linkhash.c:421:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
linkhash.c:422:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
linkhash.c:423:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
linkhash.c:424:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
linkhash.c:425:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
linkhash.c:426:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
linkhash.c:427:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
linkhash.c:428:15: warning: this statement may fall through [-Wimplicit-fallthrough=]

Can you please take a look?

@hawicz
Copy link
Member

hawicz commented Mar 20, 2017

I expect those locations need /* FALLTHRU */ comments added. Pull requests are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants