Skip to content

Fix issue with validating serialization converter #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

gregsdennis
Copy link
Collaborator

Description

Fixes an issue with mapping external types into the validating serialization converter.

Links

Resolves #791

Checks

@gregsdennis gregsdennis changed the title replicate test Fix issue with validating serialization converter Sep 20, 2024
Copy link

github-actions bot commented Sep 20, 2024

Test Results

   15 files  ±0      1 errors   14 suites  ±0   5s ⏱️ ±0s
4 668 tests ±0  4 514 ✅ ±0  154 💤 ±0  0 ❌ ±0 
4 720 runs  ±0  4 566 ✅ ±0  154 💤 ±0  0 ❌ ±0 

For more details on these parsing errors, see this check.

Results for commit 08c8464. ± Comparison against base commit 0169522.

This pull request removes 6 and adds 2 tests. Note that renamed tests count towards both.
  "foo": 42
  42
Json.JsonE.Tests.TruthyTests ‑ IsTruthy([
Json.JsonE.Tests.TruthyTests ‑ IsTruthy({
],True)
},True)
Json.JsonE.Tests.TruthyTests ‑ IsTruthy([
  42
],True)
Json.JsonE.Tests.TruthyTests ‑ IsTruthy({
  "foo": 42
},True)

♻️ This comment has been updated with latest results.

@gregsdennis gregsdennis merged commit eb63eaf into master Sep 20, 2024
6 of 7 checks passed
@gregsdennis gregsdennis deleted the schema/serialized-validation-external-type branch September 20, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValidatingJsonConverter doesn't respect OutputFormat when MapType<>(JsonSchema) is used
1 participant