Skip to content

Conversation

c-martinez
Copy link

Angular input type number already provides this functionality, so why not use it? This of course may be redundant with validators, but validators can do 'more complex' types of validations -- this only prevents scroller from rolling outside given range.

@Anthropic
Copy link
Member

@c-martinez thanks for the PR, sorry it took so long I hadn't been watching this repo well enough, ideally this would have to use the new builder which makes adding the values quite easy when needed while leaving them off if they are not required. An example of which is in the Material Decorator. If you can update to mimic that there is a greater chance I can accept it. It would also be really ehlpful as I personally don't use this decorator.

@Anthropic
Copy link
Member

Ironically I actually submitted a bug report on this exact issue, but it was for someone else #18

@c-martinez
Copy link
Author

Hi @Anthropic -- I'm not sure to understand what do you mean by the new builder -- do you mean gulp build ? Just want to be sure what I am looking for on the Material Decorator before start making changes.

@Anthropic
Copy link
Member

In the documentation there is reference made to the new builder, basically when you look at the material decorator js file you can see a bunch of functions that modify the template fragments before they get injected into the page using pure javascript.

@c-martinez
Copy link
Author

@Anthropic -- how does this look ?

@Anthropic
Copy link
Member

@c-martinez I just added this to the Angular Schema Form repo for you! Like moments ago. The function needed to take into account minimum, exclusiveMinimum, maximum, exclusiveMaximum and multipleOf rather than min, max and step.

You can see it here: https://github.com/json-schema-form/angular-schema-form/blob/b5977219a14e2de148b2f8b12197a32b3b7977d8/src/services/builder.js#L162

So it will be in version 1, just can't promise the timeline just yet.

@c-martinez
Copy link
Author

ah, cool -- perfect, that sorts it then. Look forward to version 1 then :-)

@Anthropic Anthropic closed this May 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants