Skip to content

Obey pristine success option #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2016
Merged

Obey pristine success option #771

merged 1 commit into from
Sep 25, 2016

Conversation

edclements
Copy link
Contributor

@edclements edclements commented Sep 23, 2016 •
edited by Anthropic
Loading

Description

This fixes the issue whereby the pristine success option was being ignored

Fixes Related issues

Fixes #680

Checklist

  • I have read and understand the CONTRIBUTIONS.md file
  • I have searched for and linked related issues
  • I have created test cases to ensure quick resolution of the PR is easier
  • I am NOT targeting main branch
  • I did NOT include the dist folder in my PR

@json-schema-form/angular-schema-form-lead

@Anthropic Anthropic merged commit e13c7a9 into json-schema-form:development Sep 25, 2016
Anthropic added a commit that referenced this pull request Sep 25, 2016
@Anthropic
Migration of #771 to webpack branch
b4ea417
@Anthropic
Copy link
Member

Anthropic commented Sep 25, 2016 •
edited
Loading

Thanks @edclements I had the time to copy the change into @dorin-niscu 's plunker and it works so I've merged and added it to the new webpack branch.

Hopefully it wont be too long till we can get it out in a release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
migrated: to webpack type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pristine option does nothing
2 participants
@edclements @Anthropic