This repository was archived by the owner on Nov 2, 2023. It is now read-only.
Make migration notes more prominent, update for recent developments #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the info in these documents was stale and potentially confusing.
I keep having a hard time finding them in the paragraph, so other people probably do, too. Or at least I'd like to think I'm not the only one.
adamvoss
approved these changes
Oct 1, 2017
There was a problem hiding this comment.
Submitted handrews#1 with a potential change. Otherwise I saw no issues.
Emphasize the initial link to the migration notes page a bit more, but leave the section further down as people still often miss links in text. Rework the meta-schema instructions as all-bold was too heavy and obscured the important parts of the sentence. Change "Other versions" to "Older drafts" to be more clear about what the link points to. There are not other versions in the sense of other currently valid versions.
|
@adamvoss I made some changes in the direction that you suggested, but kept the section. As a reminder (to myself as well as I am guilty of forgetting this and encourage you to call me on it the next time it happens), the goal of reviewing PRs here is:
The goal is not web site design by committee. Although arguably that's what we end up with anyway, but that's a topic for elsewhere. A full re-design would be something to work out with @Relequestual when he has time to consider it. |
Relequestual
approved these changes
Oct 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the info in the FAQs was stale and potentially confusing.
Also, I keep having a hard time finding them in the paragraph, so other people probably do, too. Or at least I'd like to think I'm not the only one.
I built the site and went through and checked each link.