-
-
Notifications
You must be signed in to change notification settings - Fork 214
sort implementations by most recent draft support #466
Conversation
✅ Deploy Preview for condescending-hopper-c3ed30 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cf12f91
to
d500e00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks great - one suggestion that you're welcome to disregard if you'd prefer, and one place I think you missed a thing if I'm reading right.
_data/validator-libraries-modern.yml
Outdated
draft: [4, 3] | ||
license: LGPL-3.0 | ||
notes: "Draft-06+ progress: issue [17](https://github.com/netmail-open/wjelement/issues/17#issuecomment-390899432)" | ||
notes: All known implementations are now obsolete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps "No known implementations support draft-06 or later" since casual readers won't know what "obsolete" means, probably not even if we document it somewhere.
_data/validator-libraries-modern.yml
Outdated
@@ -322,7 +309,7 @@ | |||
url: https://json-everything.net | |||
date-draft: [2020-12, 2019-09] | |||
draft: [7, 6] | |||
notes: Powered by JsonSchema.Net; server-side validation | |||
notes: Powered by JsonSchema.Net in Blazor WASM for client-side validation | |||
- name: jsonschema.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like jschon.dev (2020-12) and "JSON Schema Validator" (2019-09) should move above jsonschema.dev.
I've sorted the implementations list by putting the ones with support for the most recent drafts toward the top.
I'd also like to clean up the list by moving some of these to the "obsolete" file, but I'm not sure what our cutoff should be.
I've moved anything that doesn't support draft 6 or later to obsolete. If I bump that to draft 7, four more will move. The vast majority still don't support 2019-09 or later (at least not as described in our file).