Improve "x-" keyword description #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 11, 2024
Relequestual
approved these changes
Jun 18, 2024
jdesrosiers
reviewed
Jun 19, 2024
There was a problem hiding this comment.
Honestly, this still feels unclear to me. Readers have to make the connection that "implicitly defined" means that it's considered "recognized" by the implementation. I think it would be a lot easier on readers if we use the same terms in all the places we talk about this.
jdesrosiers
approved these changes
Jun 19, 2024
|
(Ref: #1512 (comment)) |
|
Still going to pull these changes in since I think the wording is a bit cleaner, even if it doesn't solve the original ask. That ask will be resolved as part of #1512. |
jviotti
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per this Slack thread, we felt that the wording here doesn't do enough to describe "x-" keywords as "known" keywords.