Skip to content

Key transform #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Key transform #32

wants to merge 7 commits into from

Conversation

beauby
Copy link
Member

@beauby beauby commented Nov 30, 2016

No description provided.

super(key_transform.call(name), options, &block)
end

def has_many(name, options = {}, &block)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename has_many to many?.

super(key_transform.call(name), options, &block)
end

def has_one(name, options = {}, &block)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename has_one to one?.

end
end

module ClassMethods

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing top-level module documentation comment.

@@ -0,0 +1,37 @@
module JSONAPI
module Serializable
module KeyTransform

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing top-level module documentation comment.

@@ -0,0 +1,37 @@
module JSONAPI

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing frozen string literal comment.

end
end

module InstanceMethods

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing top-level module documentation comment.

end
end

module ClassMethods

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing top-level module documentation comment.

@@ -0,0 +1,60 @@
module JSONAPI
module Serializable
module ConditionalFields

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing top-level module documentation comment.

@@ -0,0 +1,60 @@
module JSONAPI

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing frozen string literal comment.

@beauby
Copy link
Member Author

beauby commented Dec 1, 2016

Closing in favor of #37.

@beauby beauby closed this Dec 1, 2016
@beauby beauby deleted the key-transform branch December 1, 2016 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants