Refactor ResourceBuilder, raise exception when no serializer is found #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 3, 2017
| it 'fails with ArgumentError' do | ||
| resource = klass.new(object: user) | ||
|
|
||
| expect { |
There was a problem hiding this comment.
Avoid using {...} for multi-line blocks.
| it 'fails with NameError' do | ||
| resource = klass.new(object: user) | ||
|
|
||
| expect { |
There was a problem hiding this comment.
Avoid using {...} for multi-line blocks.
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 99.45% 99.46% +<.01%
==========================================
Files 12 12
Lines 367 371 +4
==========================================
+ Hits 365 369 +4
Misses 2 2
Continue to review full report at Codecov.
|
beauby
force-pushed
the
exception-no-serializer-found
branch
from
2c4ac71 to
617562d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.