Skip to content

Conversation

jwrobes
Copy link
Contributor

@jwrobes jwrobes commented Jun 2, 2018

  • Allows for manual scope to be used if passed as option

  - Allows for manual scope to be used if passed as option
@richmolj
Copy link
Contributor

richmolj commented Jun 2, 2018

I think this is completely solid and I'm going to go ahead and merge. That said, I was wondering if you also wanted to take a crack at including by query parameter? The thought being that if you POST a user, but have ?include=account in the request, it will be sideloaded in the response. This way we follow the standard JSONAPI practice of allowing the request to specify what it wants.

This is absolutely a win as-is in any case. Thanks so much! ❤️ 👏

@richmolj richmolj merged commit 6714bb0 into jsonapi-suite:master Jun 2, 2018
@richmolj
Copy link
Contributor

richmolj commented Jun 2, 2018

Released in 0.11.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants