attributes that are kebab-case are not camelcased correctly

[jannishuebl]

Hi,

when a attribute is in kebab-case format, which seems to be very common when using json:api, the camel case method in string.ts is not catching the attribute name.

see:

jsorm/src/util/string.ts

Line 6 in 5b28e6d

return str.replace(/(\_[a-z])/g, function($1){return $1.toUpperCase().replace('_','');});

I have not found if attribute naming-convention is somewhere defined for json:api.

I guess it should be a small fix, if you like I can take this issue over and create a pullrequest for it.

Kind Regards,

Jannis

[richmolj]

Yes, we should absolutely support this. The APIs I've seen use underscored keys, but we should support kebab-case as well. Would love to see a PR, though I'd suggest making it to the 1.x-dev branch which will be released shortly. Keep in mind we'll have to both read and write the correct keys.

Related PRs for reference #24 #21

[jannishuebl]

@richmolj thanks for the advise about the writing of the correct format. do you see any other possibility, then to add is as a configuration parameter to the model?

eg:

const Person = Model.extend({
  static {
    baseUrl: 'http://localhost:3000',
    jsonapiType: 'people',
    letterCase: 'kebab-case'
  },

letterCase could be default to 'snake_case' / 'underscored' and can be set to "kebab-case" so we do not break the current semantic.

Another possibility could be to set the separator char. eg: "_" or "-", I would prefer the first solution, what do you think about this?