Optionally add JWT to localStorage

[richmolj]

If used from the browser, you can now get/set the JWT from localStorage:

Config.setup({
  jwtOwners: [...],
  jwtLocalStorage: 'jwt' // or whatever key you'd like to set
})

jwtLocalStorage is defaulted to jwt, meaning this functionality is
opt-out. Pass false to opt-out.

When enabled, this will automatically set the JWT via local storage, and
update it when the server contains the X-JWT header.

[richmolj]

@wadetandy

[wadetandy]

I think more correct is string | false since a value of true would throw an error when using it to set the value.

[wadetandy]

Also while it makes sense to default on, there is no localStorage API on the server, so we should probably have it default more intelligently depending on whether the API exists.

[richmolj]

Config.jwtLocalStorage would == 'jwt', but no localStorage logic would fire. So I think this is OK.

Good catch on false.

[wadetandy]

Ok I’m good with this then

…

On Mon, Nov 27, 2017 at 3:28 PM Lee Richmond ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/configuration.ts <#19 (comment)>: > @@ -15,15 +15,23 @@ export default class Config { static models: Array<typeof Model> = []; static typeMapping: Object = {}; static logger: Logger = new Logger(); + static jwtLocalStorage: string | boolean = 'jwt'; Config.jwtLocalStorage would == 'jwt', but no localStorage logic would fire <https://github.com/richmolj/jsorm-1/blob/master/src/util/refresh-jwt.ts#L8>. So I think this is OK. Good catch on false. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJD9s7hVnRmJK95PWzJWLHpPey6fmEDks5s6xuKgaJpZM4QsLF9> .