Fix bug with deeply nested associations #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue when looking up/assigning a deep assocation that had already been assigned to another object would assign an empty copy of the object instead of the target. It was doing this because the return value of the lookup wasn't being used, and instead the function was inadvertently relying on the modification to the passed in parameter.
|
Good change, appreciate the spec. Thanks! 👍 |
|
I believe Github's merge button is not working at this second but ready to go when it's fixed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue when looking up/assigning a deep assocation that had
already been assigned to another object would assign an empty copy of
the object instead of the target. It was doing this because the return
value of the lookup wasn't being used, and instead the function was
inadvertently relying on the modification to the passed in parameter.