Skip to content

Conversation

jsonnull
Copy link
Owner

@jsonnull jsonnull commented Apr 22, 2018

This has turned out to be a sizeable changeset.

Here follows todos I'm tracking. More will be added as I become aware of them

Server

Types and Queries

  • User
    • User/Preferences
    • currentUser
  • Game
    • Game/MessageConnection
  • Message

Mutations

  • preferences/setChatPinned
  • preferences/setTheme
  • game/createGame
  • game/updateGameInfo
  • message/sendMessage

Subscriptions

  • message/messageAdded

Client

Queries

  • getCurrentUserGames
  • getCurrentUserPreferences
  • getCurrentUserFriends
  • getUserProfile

Fragments

  • game/gameInfo
  • user/preferences/preferencesData
  • user/friends/friendsData
  • user/profile/profileData
  • message/messageData

Mutations

  • preferences/setChatPinned
  • preferences/setTheme
  • game/createGame
  • game/updateGameInfo
  • message/sendMessage

Subscriptions

  • message/messageAdded

Testing

  • Use link-schema to create response data, use in integration tests?

Followup

  • Remove old packages
    • redux-saga
    • still need reselect?
  • Remove old code
    • sagas/
    • firebase/
    • selectors/ ?
  • Create issue to remove Firebase packages
  • Secure messages, currently does not check game membership
  • Ensure subscriptions are canceled properly on the backend

@coveralls
Copy link

coveralls commented Apr 27, 2018

Coverage Status

Coverage decreased (-15.0%) to 71.154% when pulling 6d9c839 on feature/graphql into 0706444 on master.

@jsonnull jsonnull merged commit 3d949e1 into master Apr 27, 2018
@jsonnull jsonnull deleted the feature/graphql branch April 27, 2018 00:37
@jsonnull
Copy link
Owner Author

All proper follow-up issues have been created, we're done here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants