Skip to content

Conversation

jsonnull
Copy link
Owner

@jsonnull jsonnull commented Jul 29, 2022

By passing in contextBridge, it's no longer required to pass the "electronTRPC" variable name which was hard-coded and couldn't be changed.

This also lets us change the name in the future without requiring changes when the package is upgraded.

@codecov-commenter
Copy link

Codecov Report

Merging #10 (06cbe34) into main (2ed54f9) will decrease coverage by 1.74%.
The diff coverage is 0.00%.

❗ Current head 06cbe34 differs from pull request most recent head 9cb8f3d. Consider uploading reports for the commit 9cb8f3d to get more accurate results

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   45.69%   43.94%   -1.75%     
==========================================
  Files           8        8              
  Lines         151      157       +6     
  Branches       12       12              
==========================================
  Hits           69       69              
- Misses         82       88       +6     
Impacted Files Coverage Δ
src/main/exposeElectronTRPC.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed54f9...9cb8f3d. Read the comment docs.

@jsonnull jsonnull merged commit 357842e into main Jul 29, 2022
@jsonnull jsonnull deleted the simplify-trpc-expose branch July 29, 2022 13:24
@github-actions github-actions bot mentioned this pull request Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants