Skip to content

Conversation

JoeHartzell
Copy link
Collaborator

Fixes #145.

Overview

Replaces the event.sender.send with event.reply in handleIPCMessage. This will add support for replying to multiple frames.

Changes

  • Updated handleIPCMessage
  • Update the tests to use event.reply

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for electron-trpc ready!

Name Link
🔨 Latest commit ec32979
🔍 Latest deploy log https://app.netlify.com/sites/electron-trpc/deploys/648a52fef99dc90008f9570e
😎 Deploy Preview https://deploy-preview-146--electron-trpc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jsonnull
Copy link
Owner

Hey @JoeHartzell, thanks again for creating this PR.

Can you make a couple quick fixes for me? I figure it'll be easier to ask you to do than for myself to push a new branch here with my fixes.

First, can you commit the original pnpm-lock.yaml? I'll update the deps in a minute any way, and add something in the repo to help everybody get on the same pnpm version. You should be able to do git checkout origin/main -- pnpm-lock.yaml and commit it.

Second, can you add the file .changeset/issue-145.md with this content:

---
'electron-trpc': patch
---

Fix `handleIPCMessage` only sending replies to Electron's main frame.

pr: 146

@JoeHartzell
Copy link
Collaborator Author

Yea. I can make those changes no problem!

@jsonnull jsonnull changed the title Fixed #145 Fix replies only getting routed to main frame Jun 14, 2023
@jsonnull jsonnull changed the title Fix replies only getting routed to main frame Fix replies only getting routed to main frame. Jun 14, 2023
@jsonnull jsonnull merged commit c43ae93 into jsonnull:main Jun 14, 2023
@github-actions github-actions bot mentioned this pull request Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handleIPCMessage only sends replies to electron main frame
2 participants