Skip to content

Conversation

JoeHartzell
Copy link
Collaborator

Summary

This PR addresses some QOL improvements. In an effort to reduce "duplicated" code, I found some areas where we could replace utils functions with public imports. I also improved the test coverage for the main/utils.ts file.

Changes

  1. Replaced transformTRPCResponseItem with transformTRPCResponse
    • Updated import ./utils -> @trpc/server/shared
  2. Increased test coverage of main/utils.ts to %100

@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for electron-trpc ready!

Name Link
🔨 Latest commit f2b03e0
🔍 Latest deploy log https://app.netlify.com/sites/electron-trpc/deploys/648fa296752ad000086d5260
😎 Deploy Preview https://deploy-preview-149--electron-trpc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jsonnull jsonnull merged commit 3892db5 into jsonnull:main Jun 19, 2023
@jsonnull
Copy link
Owner

In an effort to reduce "duplicated" code, I found some areas where we could replace utils functions with public imports.

I'm really excited that there's a public import for this now. Thanks so much for doing this!

@github-actions github-actions bot mentioned this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants