Clean up subscriptions when frames perform navigation. #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for electron-trpc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jsonnull
force-pushed
the
frame-navigation-subscription-cleanup
branch
from
a1dd6e7 to
fcaae14
Compare
JoeHartzell
previously approved these changes
Aug 6, 2023
|
Changes look good! We might want to add a ticket to follow up with some E2E tests for this. I think it would be pretty straight forward to test this. But overall the changes look good. |
jsonnull
force-pushed
the
frame-navigation-subscription-cleanup
branch
from
fcaae14 to
b950d7e
Compare
jsonnull
force-pushed
the
frame-navigation-subscription-cleanup
branch
from
b950d7e to
1563d6f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instruments desired cleanup brought up by #164