Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #769

Merged
merged 2 commits into from
Dec 4, 2023
Merged

chore: update dependencies #769

merged 2 commits into from
Dec 4, 2023

Conversation

SethFalco
Copy link
Member

@SethFalco SethFalco commented Dec 4, 2023

This repository has many outdated dependencies, which include security vulnerabilities.

This should address all the ones possible without code changes. The ones that require code changes will be addressed in separate pull requests.

This also drops Node.js v10 support, which has been out of maintenance for years now. In fact, Node.js v12, v14, and v16 are all out of their maintenance windows as well, but I won't drop those yet.

We currently can't test on Node.js v18 or v20 due to dependencies not supporting these versions of Node.js.

Chores

  • Run CI on pull requests.
  • In CI test on Node.js 12, 14, and 16 instead of 10, 12, and 14. (Drops Node v10 support.)
  • Add <18 in our engines as the project doesn't work properly on Node.js v18.
  • Update dependencies to adhere to security advisories.
  • Remove dependencies that appear to be unused in the project.

While this repository isn't actively maintained, I think it's worth giving it a final clean up, and adding a notice, and recommending to use other clients higher in the README.

@SethFalco SethFalco changed the title deps: update dependencies chore: update dependencies Dec 4, 2023
@SethFalco SethFalco merged commit 6101775 into jsonresume:master Dec 4, 2023
7 of 8 checks passed
@SethFalco SethFalco deleted the deps branch December 4, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant