Remove ECDSA from namshi/jose #194
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to namshi/jose#94, the implementation is non-conformant and broken.
|
Fixed in 3e67a14. Please note that the PR was wrong (removing the lines is not what was required here). In any case, thank you for your contribution. |
|
By the way, this library is now unmaintained and should be removed from the list. |
|
Thank you for your report, Spomky. We are planning to do a review to find unmaintained libraries and remove them. This is tracked in issue #277. However, thanks to your report we can remove this library before reaching that issue. Thanks again. |
sebadoom
added a commit
that referenced
this pull request
Dec 4, 2017
|
Removed in 3a7c00d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to namshi/jose#94, the implementation is non-conformant and broken.