Skip to content

Allow for finalisers #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow for finalisers #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ssh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ type PublicKey struct {

type PublicKeyContextKey struct{}
type UserContextKey struct{}
type RepositoryContextKey struct{}

const (
keyID = "key-id"
Expand All @@ -51,6 +52,7 @@ type SSH struct {
PublicKeyLookupFunc func(ctx context.Context, publicKeyPayload string) (*PublicKey, error)
PreLoginFunc func(ctx context.Context, metadata ssh.ConnMetadata) error
AuthoriseOperationFunc func(ctx context.Context, cmd *GitCommand) error
FinaliseFunc func(ctx context.Context)
}

func NewSSH(config Config) *SSH {
Expand Down Expand Up @@ -233,6 +235,9 @@ func (s SSH) handleExecRequest(ctx context.Context, ch ssh.Channel, req *ssh.Req
return fmt.Errorf("ssh: command failed: %w", err)
}

ctx = context.WithValue(ctx, RepositoryContextKey{}, gitcmd)
s.FinaliseFunc(ctx)

_, err = ch.SendRequest("exit-status", true, []byte{0, 0, 0, 0})

return
Expand Down Expand Up @@ -283,6 +288,10 @@ func (s SSH) defaultPreLoginFunc(ctx context.Context, metadata ssh.ConnMetadata)
return nil
}

func (s SSH) defaultFinaliseFunc(ctx context.Context) {
return
}

func (s *SSH) setup() error {
if s.sshconfig != nil {
return nil
Expand All @@ -307,6 +316,10 @@ func (s *SSH) setup() error {
s.PreLoginFunc = s.defaultPreLoginFunc
}

if s.FinaliseFunc == nil {
s.FinaliseFunc = s.defaultFinaliseFunc
}

config.PublicKeyCallback = func(conn ssh.ConnMetadata, key ssh.PublicKey) (*ssh.Permissions, error) {
ctx := context.WithValue(context.Background(), UserContextKey{}, conn.User())
err := s.PreLoginFunc(ctx, conn)
Expand Down