Cannot edit own test

[madskonradsen]

It doesn't seem possible to edit my own tests as it just creates a new page instead of updating as request.yar.get('own') never gets set. It might just be something with my setup.

[maxbeatty]

confirmed yar.set('own') isn't happening outside of unit tests. wondering if we should instead persist something from GH auth to find "own"

[madskonradsen]

But we don't store anything unique about the user when they create a page, how would we know, across browser sessions, that they did in fact create a particular page? Should the pages-entity be extended with another column containing something from GH auth, and how can we avoid people tampering with the data in the callback from Github?
EDIT: Just saying that if we chose to store something from the GH authentification, it can't be the email-address as it would be easy to just replace in the callback.

[maxbeatty]

correct, we would need to alter the mysql schema to store something unique from their profile

how can we avoid people tampering with the data in the callback from Github?

OAuth is trustworthy enough for me

[madskonradsen]

Oh... It's using OAuth... No problem then. Maybe i should have verified how the integration worked before blabbering ;)

[madskonradsen]

Just leaving a link to the bulkUpdate-edit-issue: #143 (comment)

[mathiasbynens]

correct, we would need to alter the mysql schema to store something unique from their profile

This is needed for #232 as well.

[JonasNo]

I do not understand why this is so hard to fix. It worked before. Why not use the git repo history to track down what changes broke the site?
I would but I don't know how to setup this, make it run and ability to debug. I know Javascript but not the other stuff (server/client). Yes I've read the instructions but since I do not know how this will affect my machine I'm worried about accidentally opening up my machine to internet or breaking something locally.
Is this project abandoned?

[madskonradsen]

No, this project is not abandoned. In case you havn't noticed is this an open-source project. People don't get paid. People do this because they think it's fun. Pay people to fix it, wait, or fix it yourself.

[JonasNo]

You did not understand the question. When an open source project is considered abandoned the original author(s) have lost interest in it. Basically drops the ball and walks away.

In case you havn't noticed is this an open-source project. People don't get paid. People do this because they think it's fun. Pay people to fix it, wait, or fix it yourself.

What's with that condescending attitude? Such a waste of time. So unnecessary and uncalled for. Learn to control your damage and keep it to yourself. Talk to a friend or a professional or both, please. There are even forums for it. This site is however not the place.

[madskonradsen]

"I do not understand why this is so hard to fix." is what's up.

[mathiasbynens]

I do not understand why this is so hard to fix. It worked before. Why not use the git repo history to track down what changes broke the site?

The project has been rewritten from scratch in Node.js. The old version was PHP-based. There is no change that broke this — it just hasn’t been implemented yet in the new version. If you had taken your own advice and “used the git repo history” you would’ve known this already.

[jdalton]

"I do not understand why this is so hard to fix." is what's up.

A PR is worth more than a thousand pings.