End 2 end tests #134
Merged
End 2 end tests #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .editorconfig | ||
| .env | ||
| .eslintignore | ||
| .eslintrc |
There was a problem hiding this comment.
want these to be included in the e2e_runner container so lab can lint e2e test files
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the app is getting more use and bugs are popping up outside of what unit tests will easily catch, it's time to add some end to end tests (full browser automation).
This uses a new Docker Compose configuration of a Selenium Grid Hub and Selenium Grid Nodes (Firefox because that's built-in) along with the existing Docker Compose containers and lab test framework to run tests locally.
I also updated some of the documentation and steps to get up and running. In order for these to run on Travis, we'll need to modify the setup so it's automated. This PR is already big enough and is going to create merge conflicts for others so may save that for another more manageable branch.