Skip to content

add caching #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2017
Merged

add caching #406

merged 2 commits into from
Jul 11, 2017

Conversation

maxbeatty
Copy link
Member

closes #136

caching could be added to more places but will wait for performance bottlenecks. I used a free Redis Labs instance which would likely suit our needs or running redis in a Docker container on Zeit.

@maxbeatty maxbeatty self-assigned this Jul 10, 2017
mathiasbynens
mathiasbynens approved these changes Jul 10, 2017
View reviewed changes
Copy link
Contributor

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that this degrades gracefully when the REDIS_* vars are not set. LGTM.

What’s with the failing builds? (Seems unrelated to this patch)

@maxbeatty
Copy link
Member Author

:shipit:

@mathiasbynens mathiasbynens merged commit 33332b4 into master Jul 11, 2017
@mathiasbynens mathiasbynens deleted the cache branch July 11, 2017 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

@asilluron asilluron Awaiting requested review from asilluron

Assignees

@maxbeatty maxbeatty

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider adding caching
2 participants
@maxbeatty @mathiasbynens