-
Notifications
You must be signed in to change notification settings - Fork 127
Fix tests not being saved when editing an existing page. #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @maxbeatty , can you merge this? |
@mathiasbynens will you refresh me when a test should be updated? |
@maxbeatty Is there anything missing stopping this from being merged? |
@elxa please be patient. I am waiting on Mathias to clarify when a test should be updated. That response will clarify whether this is a change we should make. I will submit a review when I have all of information I need. Thank you for your contribution, but please be patient. |
When the test’s owner edits the test while still logged in to the same session (cookie-wise). On the old jsPerf, that used to be an 8-hour window, but that’s an implementation detail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe this addresses the root cause of the referenced issue. There's no difference in the session from the first time a page is created to a later date when it is edited which causes tests to always update. A more robust change is needed but I don't fully understand it yet.
Fixes jsperf#236 Pretty much similar to jsperf#414, but with an added test to show issue.
Fixes jsperf#236 Pretty much similar to jsperf#414, but with an added test to show issue.
Fixes jsperf#236 Pretty much similar to jsperf#414, but with an added test to show issue.
Fixes #236
Looks like ownership verification is broken. If Name aka author is set your are the owner???