Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .snyk
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
version: v1.5.0
ignore: {}
patch:
'npm:marked:20150520':
- marked:
patched: '2016-07-25T01:12:09.411Z'
patch: {}
7 changes: 7 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,13 @@ In one terminal, have jsPerf running (`npm start`). In another, have webdriver-m
SELENIUM_SERVER=http://127.0.0.1:4444/wd/hub npm run test-e2e
```

### Known Globals

Lab detects global variable leaks. Sometimes downstream dependencies make this unavoidable so we ignore specific variables in the `lab` command for `npm test` (`package.json#scripts.test`). Here are the known globals with explanations:

- `__core-js_shared__` stems from `core-js`?
- `__grim__` stems from `grim`, a dependency of `marky-markdown` (`npm ls grim`)

## Adding new dependencies

Install using `npm` and either `--save` or `--save-dev`. **Do not edit `package.json` manually.**
2 changes: 1 addition & 1 deletion config.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const envSchema = Joi.object().keys({
const result = Joi.validate(process.env, envSchema);

if (result.error) {
throw new Error(`${result.error.details[0].path} environment variable is missing`);
throw new Error(`${result.error.details[0].path[0]} environment variable is missing`);
}

var Confidence = require('confidence');
Expand Down
Loading