Skip to content

docs: added section on customizing wildcard import identifier in module documentation #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

EGAMAGZ
Copy link
Contributor

@EGAMAGZ EGAMAGZ commented Feb 19, 2025

Referenced issue #725 to add this information and example to the documentation

@EGAMAGZ
Copy link
Contributor Author

EGAMAGZ commented Feb 19, 2025

It throws linting errors not related to what I did, I could fix them but some should not such as dangerouslySetInnerHTML usage 😅.

@crowlKats
Copy link
Collaborator

yes in the latest deno release we added new linting capabilities. feel free to fix them, and add lint ignores on the dangeroushtml stuff

@EGAMAGZ
Copy link
Contributor Author

EGAMAGZ commented Feb 19, 2025

Got it, thanks for the update! No worries, I'll take care of the linting errors. Appreciate the heads-up!

@EGAMAGZ
Copy link
Contributor Author

EGAMAGZ commented Feb 19, 2025

@crowlKats done. Linting erros fixed :D

Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing the lints! LGTM

@crowlKats crowlKats added this pull request to the merge queue Feb 19, 2025
@EGAMAGZ
Copy link
Contributor Author

EGAMAGZ commented Feb 19, 2025

No problem at all, it's my pleasure! :D

Merged via the queue into jsr-io:main with commit 48c3a59 Feb 19, 2025
6 checks passed
@EGAMAGZ EGAMAGZ deleted the feat/module-example branch February 19, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants