Node: Initial implementation and responses #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnyob
force-pushed
the
ajob410@node/responses
branch
2 times, most recently
from
9c5b0d1
to
f3f4c28
Compare
johnyob
changed the base branch from
main
to
ajob410@kernel/signed-operations
johnyob
force-pushed
the
ajob410@node/responses
branch
from
f3f4c28
to
c630091
Compare
johnyob
force-pushed
the
ajob410@node/responses
branch
from
c630091
to
439db52
Compare
Merged
johnyob
changed the title
johnyob
force-pushed
the
ajob410@node/responses
branch
from
439db52
to
2c40064
Compare
alanmarkoTrilitech
requested changes
Oct 27, 2023
sam-finch-tezos
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Approved, but will trust you to address @alanmarkoTrilitech's comments
johnyob
force-pushed
the
ajob410@kernel/signed-operations
branch
from
cc786d4
to
d151db5
Compare
johnyob
force-pushed
the
ajob410@node/responses
branch
2 times, most recently
from
2e375c7
to
67ad895
Compare
…point This commit creates the `jstz_node` binary: a HTTP server (using actix-web) with logging. Additionally it implements the GET /operations/<hash>/receipt endpoint (using `Rollup`) to read the receipt from the rollup node's durable storage.
johnyob
force-pushed
the
ajob410@node/responses
branch
from
67ad895
to
9ca3216
Compare
|
@alanmarkoTrilitech ping for reapproval |
|
I can't run cargo run --bin jstz-node due to this error: |
alanmarkoTrilitech
approved these changes
Oct 31, 2023
|
I'll add an asana task for a design doc of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Related Tasks: Create a RPC node, Response Getter
The
jstz_nodewill be a side-car service to the jstz rollup node. It's purpose will be communicating with the rollup using external messages, thekernel.logfile (which we will eventually refactor into a one-way channel), and reading storage from the rollup node.Description
Dependencies: #64, #77
This PR implements:
jstz_nodebinary: a HTTP server (using actix-web) with logging.GET /operations/<hash>/receiptendpoint (usingRollup) to read the receipt from the rollup node's durable storageManually testing the PR
Using the hash
hfrom the signed operation, curlhttp://localhost:8933/operations/<h>/receipt