-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cli: Operation signing + login
and whoami
#77
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnyob
force-pushed
the
alan@cli_enhancements/op_signing
branch
from
October 27, 2023 11:04
3638dbf
to
9a7f3de
Compare
@alanmarkoTrilitech please add context + description (useful for looking back on this PR) |
johnyob
approved these changes
Oct 27, 2023
johnyob
changed the title
Cli_enhancements: Operation signing + Login/WhoAmI
Cli: Operation signing + Oct 27, 2023
login
and whoami
Additionally requesting a review from @sam-finch-tezos |
This was referenced Oct 27, 2023
Merged
ryutamago
reviewed
Oct 29, 2023
sam-finch-tezos
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor fixes otherwise looks good
Co-authored-by: Sam Finch <sam.finch@trili.tech>
Co-authored-by: Sam Finch <sam.finch@trili.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
https://app.asana.com/0/1205170694555918/1205647566435497
https://app.asana.com/0/1205170694555918/1205670949626073
https://app.asana.com/0/1205170694555918/1205670949626067
Description
This PR adds support for signing operations using a secret key and Login/WhoAmI commands for setting the current account.
Manually testing the PR
cargo run -- account create alan
cargo run -- account create login alan
cargo run -- account whoami
cargo run -- deploy --function_code "console.log('Hello');"
cargo run -- run $url