Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli: Operation signing + login and whoami #77

Merged
merged 10 commits into from
Oct 30, 2023

Conversation

alanmarkoTrilitech
Copy link
Collaborator

@alanmarkoTrilitech alanmarkoTrilitech commented Oct 26, 2023

Context

https://app.asana.com/0/1205170694555918/1205647566435497
https://app.asana.com/0/1205170694555918/1205670949626073
https://app.asana.com/0/1205170694555918/1205670949626067

Description

This PR adds support for signing operations using a secret key and Login/WhoAmI commands for setting the current account.

Manually testing the PR

cargo run -- account create alan
cargo run -- account create login alan
cargo run -- account whoami
cargo run -- deploy --function_code "console.log('Hello');"
cargo run -- run $url

@johnyob johnyob force-pushed the alan@cli_enhancements/op_signing branch from 3638dbf to 9a7f3de Compare October 27, 2023 11:04
@johnyob
Copy link
Collaborator

johnyob commented Oct 27, 2023

@alanmarkoTrilitech please add context + description (useful for looking back on this PR)

@johnyob johnyob changed the title Cli_enhancements: Operation signing + Login/WhoAmI Cli: Operation signing + login and whoami Oct 27, 2023
@johnyob
Copy link
Collaborator

johnyob commented Oct 27, 2023

Additionally requesting a review from @sam-finch-tezos

@alanmarkoTrilitech alanmarkoTrilitech marked this pull request as ready for review October 27, 2023 11:31
This was referenced Oct 27, 2023
jstz_cli/src/repl.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@sam-finch-tezos sam-finch-tezos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor fixes otherwise looks good

jstz_cli/src/repl.rs Outdated Show resolved Hide resolved
jstz_proto/src/context/account.rs Outdated Show resolved Hide resolved
jstz_cli/src/run.rs Outdated Show resolved Hide resolved
jstz_cli/src/repl.rs Outdated Show resolved Hide resolved
alanmarkoTrilitech and others added 5 commits October 30, 2023 14:36
Co-authored-by: Sam Finch <sam.finch@trili.tech>
Co-authored-by: Sam Finch <sam.finch@trili.tech>
@alanmarkoTrilitech alanmarkoTrilitech merged commit 6d46389 into main Oct 30, 2023
5 checks passed
@alanmarkoTrilitech alanmarkoTrilitech deleted the alan@cli_enhancements/op_signing branch October 30, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants