Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing simple Linux CI based on GitHub Actions via pull request welcome? #45

Open
hartwork opened this issue Nov 5, 2023 · 4 comments

Comments

@hartwork
Copy link
Contributor

hartwork commented Nov 5, 2023

Hi!

I noticed that this repository does not have any CI so that currently pull requests could in theory break compilation unnoticed any time even with careful review. Use of GitHub Actions would be free of cost for you, works well, and only requires addition of a single YAML file to activate. I'm thinking of an approach similar to https://github.com/projectM-visualizer/frontend-libvisual-plug-in/blob/master/.github/workflows/linux.yml , aiming to cover at least GCC 12 and Clang 17 here. What do you think?

Best, Sebastian

@jsummers
Copy link
Owner

jsummers commented Nov 8, 2023

I appreciate the suggestion and offer. I'll give it some more thought, but I don't think I'm prepared to do that at this time.

@hartwork
Copy link
Contributor Author

hartwork commented Nov 9, 2023

@jsummers to avoid misunderstandings, the plan was to provide a pull request for you so you would not need to "do" anything in the sense of building things and the level of detail in review would be up to you. Did you mean to say you're not prepared for a repository with active CI or no prepared for building CI yourself? Would be great to be sure, thanks!

@hartwork hartwork changed the title Contributing simple Linux CI based on GitHub Actions welcome? Contributing simple Linux CI based on GitHub Actions via pull request welcome? Nov 10, 2023
@jsummers
Copy link
Owner

I don't want to selfishly dismiss this out of hand, if it would be useful to other people.

But I'm just not interested in taking the time to learn about GitHub Actions right now. I'm uneasy about committing magic files to my project, without a good understanding of what I'd be getting into.

@hartwork
Copy link
Contributor Author

@jsummers okay, I consider https://github.com/projectM-visualizer/frontend-libvisual-plug-in/blob/master/.github/workflows/linux.yml more of a YAML shell script rather than magic, but I will not push for it any further then, I understand and respect the need to understand contributions on detail level. Whenever you change your mind, let me know, I'm happy to do free-of-cost voice call consulting on basic GitHub Actions to get you to detail level understanding whenever you're ready. Have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants