Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store and reuse interim results #102

Closed
wants to merge 1 commit into from

Conversation

PaulSzymanski
Copy link

This speeds up random walks significantly.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0dae4b0 on PaulSzymanski:reuse into 6968649 on jsvine:master.

@jsvine
Copy link
Owner

jsvine commented Oct 11, 2018

Thanks, @PaulSzymanski! Certainly seems worth exploring. A few questions for you and for repository-watchers:

  1. I'm a bit concerned about how this change would affect memory usage, especially for very large corpora. Do you have any benchmarks to share on that?

  2. Given the above, what do you think of making this feature opt-in, via a keyword argument. E.g., cache_interim_results = True, memoize = True, or somesuch?

  3. Thoughts of using if state in self.mem: rather than the try/except block?

@jsvine
Copy link
Owner

jsvine commented Jan 6, 2020

Closing, due to the fact that this concept was implemented in #113. Feel free to reopen and/or comment, however, if you disagree. Thanks!

@jsvine jsvine closed this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants