Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #1973 #4

Closed
wants to merge 1 commit into from
Closed

Fixed issue #1973 #4

wants to merge 1 commit into from

Conversation

libm
Copy link

@libm libm commented Jul 2, 2014

nwjs/nw.js#1973
Some attributes should be available even after the frame is destroyed.

@libm libm mentioned this pull request Jul 2, 2014
Closed
Fixed issue #1973
7cc0fb9 
nwjs/nw.js#1973
Some attributes should be available even after the frame is destroyed.
rogerwang
rogerwang reviewed Jul 13, 2014
View reviewed changes
Source/bindings/v8/custom/V8WindowCustom.cpp
if (frame->isNwFakeTop()) {
v8SetReturnValue(info, v8::Null(info.GetIsolate()));
return;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you move the block to a later position?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, the frame may have been destroyed and the frame pointer is null. This checking is done by 'BindingSecurity::shouldAllowAccessToNode' (like openerAttributeSetterCustom does), therefore the best approach is to move this block behind.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there is some side effect if we move it later.

@libm
Copy link
Author

libm commented Jul 15, 2014

@rogerwang would you pls have a look?

GnorTech pushed a commit that referenced this pull request Sep 25, 2014
Revert of Make DOMWrapperWorld::current() return a reference instead …
0f588d3 
…of a pointer (https://codereview.chromium.org/209713003/)

Also reverting dependent patch https://codereview.chromium.org/213543004

Reason for revert:
Likely to have caused memory leaks:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/989/steps/browser_tests/logs/stdio#failure1

(1)
Direct leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
    #1 0x9bdfd8a in WebCore::V8PerContextDataHolder::install(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:56
    #2 0x9bdfa06 in WebCore::V8PerContextData::V8PerContextData(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:108
    #3 0x9bc1afd in WebCore::V8PerContextData::create(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.h:66:16
    #4 0x9be64fc in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132

(2)
Indirect leak of 40 byte(s) in 1 object(s) allocated from:
    #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
    #1 0x9b2ee18 in operator new third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:59:22
    #2 0x9b2ee18 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53
    #3 0x9be64e7 in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132
 
(3)
Indirect leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x4b46c1 in __interceptor_malloc /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:75
    #1 0x62caf0a in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:533
    #2 0x62caf0a in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:549
    #3 0x62caf0a in WTF::fastMalloc(unsigned long) third_party/WebKit/Source/wtf/FastMalloc.cpp:125
    #4 0x9b2ed61 in operator new third_party/WebKit/Source/wtf/RefCounted.h:175
    #5 0x9b2ed61 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53

Original issue's description:
> Make DOMWrapperWorld::current() return a reference instead of a pointer
> 
> Now that it's guaranteed that DOMWrapperWorld is not 0 at any given time, we can make it a reference instead of a pointer.
> 
> BUG=341032
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170261

TBR=jochen@chromium.org,dcarney@chromium.org,abarth@chromium.org,haraken@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=341032

Review URL: https://codereview.chromium.org/217053007

git-svn-id: svn://svn.chromium.org/blink/trunk@170357 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech pushed a commit that referenced this pull request Sep 25, 2014
Revert 170357 "Revert of Make DOMWrapperWorld::current() return ..."
8961684 
This is a revert of the revert of r170261.
r170261 was reverted because it introduced new memory leaks, but the leaks were false-positive.

> Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer (https://codereview.chromium.org/209713003/)
> 
> Also reverting dependent patch https://codereview.chromium.org/213543004
> 
> Reason for revert:
> Likely to have caused memory leaks:
> http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/989/steps/browser_tests/logs/stdio#failure1
> 
> (1)
> Direct leak of 32 byte(s) in 1 object(s) allocated from:
>     #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
>     #1 0x9bdfd8a in WebCore::V8PerContextDataHolder::install(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:56
>     #2 0x9bdfa06 in WebCore::V8PerContextData::V8PerContextData(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:108
>     #3 0x9bc1afd in WebCore::V8PerContextData::create(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.h:66:16
>     #4 0x9be64fc in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132
> 
> (2)
> Indirect leak of 40 byte(s) in 1 object(s) allocated from:
>     #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
>     #1 0x9b2ee18 in operator new third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:59:22
>     #2 0x9b2ee18 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53
>     #3 0x9be64e7 in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132
>  
> (3)
> Indirect leak of 24 byte(s) in 1 object(s) allocated from:
>     #0 0x4b46c1 in __interceptor_malloc /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:75
>     #1 0x62caf0a in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:533
>     #2 0x62caf0a in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:549
>     #3 0x62caf0a in WTF::fastMalloc(unsigned long) third_party/WebKit/Source/wtf/FastMalloc.cpp:125
>     #4 0x9b2ed61 in operator new third_party/WebKit/Source/wtf/RefCounted.h:175
>     #5 0x9b2ed61 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53
> 
> Original issue's description:
> > Make DOMWrapperWorld::current() return a reference instead of a pointer
> > 
> > Now that it's guaranteed that DOMWrapperWorld is not 0 at any given time, we can make it a reference instead of a pointer.
> > 
> > BUG=341032
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170261
> 
> TBR=jochen@chromium.org,dcarney@chromium.org,abarth@chromium.org,haraken@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=341032
> 
> Review URL: https://codereview.chromium.org/217053007

TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/218813002

git-svn-id: svn://svn.chromium.org/blink/trunk@170424 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech pushed a commit that referenced this pull request Sep 25, 2014
Revert of IDL: Support optional argument default value syntax (https:…
4a1fd1c 
…//codereview.chromium.org/312683005/)

Reason for revert:
This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905

BrowserTestBase signal handler received SIGTERM. Backtrace:
#0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace()
#1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f2c232cd4a0 \u003Cunknown>
#3 0x7f2c2337f313 __poll
#4 0x7f2c240b6036 \u003Cunknown>
#5 0x7f2c240b6164 g_main_context_iteration
#6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run()
#7 0x7f2c2a29eed7 base::MessageLoop::RunHandler()
#8 0x7f2c2a2f69d8 base::RunLoop::Run()
#9 0x00000466bd59 content::RunThisRunLoop()
#10 0x00000466c1b8 content::MessageLoopRunner::Run()
#11 0x000004610946 content::TitleWatcher::WaitAndGetTitle()
#12 0x0000011fdf00 MediaBrowserTest::RunTest()
#13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage()
#14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage()
#15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange()
#16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread()
...

Please look into it. An alterate possible candidate is  https://codereview.chromium.org/327553002 but I think that's less likely.

Original issue's description:
> IDL: Support optional argument default value syntax
> 
> Adds support for parsing default values of different types, but
> only handles null default values when generating code.
> 
> Replaces existing
> 
>   [Default=Null] optional SomeInterface arg
>   [Default=NullString] optional DOMString arg
> 
> with the now equivalent
> 
>   optional SomeInterface arg = null
>   optional DOMString arg = null
> 
> in IDL files, and drops support for those [Default] attributes.
> 
> No changes to generated code.
> 
> BUG=258153
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200

TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=258153

Review URL: https://codereview.chromium.org/339683002

git-svn-id: svn://svn.chromium.org/blink/trunk@176220 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech pushed a commit that referenced this pull request Sep 25, 2014
Revert of Revert of IDL: Support optional argument default value synt…
356a3bd 
…ax (https://codereview.chromium.org/339683002/)

Reason for revert:
Revert the revert because the bot went green even without this revert, and other bots had no trouble.

Original issue's description:
> Revert of IDL: Support optional argument default value syntax (https://codereview.chromium.org/312683005/)
> 
> Reason for revert:
> This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905
> 
> BrowserTestBase signal handler received SIGTERM. Backtrace:
> #0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace()
> #1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler()
> #2 0x7f2c232cd4a0 \u003Cunknown>
> #3 0x7f2c2337f313 __poll
> #4 0x7f2c240b6036 \u003Cunknown>
> #5 0x7f2c240b6164 g_main_context_iteration
> #6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run()
> #7 0x7f2c2a29eed7 base::MessageLoop::RunHandler()
> #8 0x7f2c2a2f69d8 base::RunLoop::Run()
> #9 0x00000466bd59 content::RunThisRunLoop()
> #10 0x00000466c1b8 content::MessageLoopRunner::Run()
> #11 0x000004610946 content::TitleWatcher::WaitAndGetTitle()
> #12 0x0000011fdf00 MediaBrowserTest::RunTest()
> #13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage()
> #14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage()
> #15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange()
> #16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread()
> ...
> 
> Please look into it. An alterate possible candidate is  https://codereview.chromium.org/327553002 but I think that's less likely.
> 
> Original issue's description:
> > IDL: Support optional argument default value syntax
> > 
> > Adds support for parsing default values of different types, but
> > only handles null default values when generating code.
> > 
> > Replaces existing
> > 
> >   [Default=Null] optional SomeInterface arg
> >   [Default=NullString] optional DOMString arg
> > 
> > with the now equivalent
> > 
> >   optional SomeInterface arg = null
> >   optional DOMString arg = null
> > 
> > in IDL files, and drops support for those [Default] attributes.
> > 
> > No changes to generated code.
> > 
> > BUG=258153
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200
> 
> TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=258153
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176220

TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=258153

Review URL: https://codereview.chromium.org/339723002

git-svn-id: svn://svn.chromium.org/blink/trunk@176231 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech pushed a commit that referenced this pull request Sep 25, 2014
FetchEvent should not forcibly reject an unresolved Promise when dest…
e414ddb 
…ructed

Currently an unresolved Promise on RespondWithObserver is forcibly rejected
when the RespondWithObserver is destructed. This means that an unresolved Promise
registered with fetchEvent.respondWith() is forcibly rejected when the fetchEvent
is destructed. This behavior is not good because it makes GC observable.
(For more details, see comment #2 and #4 in the CL discussion.)

Given the above, this CL stops rejecting an unresolved Promise in
RespondWithObserver's destructor. Also this CL removes a test that were
testing the behavior. The removed test should hang after this change
(because an unresolved Promise is never resolved nor rejected).

BUG=400645

Review URL: https://codereview.chromium.org/442183003

git-svn-id: svn://svn.chromium.org/blink/trunk@179695 bbb929c8-8fbe-4397-9dbb-9b2b20218538
jtg-gg pushed a commit to jtg-gg/blink that referenced this pull request Nov 14, 2014
@rogerwang
Properly find Frame from Node context
b4053e8 
or debug callback can't get the listener.
Fix nwjs/nw.js#719

#0  WebCore::InspectorDebuggerAgent::didPause (this=0x7ffff7ee8800,
    scriptState=0x192e07eebb10, callFrames=..., exception=...)
    at ../../third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp:682
#1  0x0000000003665f7e in WebCore::ScriptDebugServer::breakProgram (
    this=0x7ffff7ee8260, executionState=..., exception=...)
    at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:425
nwjs#2  0x0000000003666ceb in WebCore::ScriptDebugServer::handleV8DebugEvent (
    this=0x7ffff7ee8260, eventDetails=...)
    at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:503
nwjs#3  0x0000000003666012 in WebCore::ScriptDebugServer::v8DebugEventCallback (
    eventDetails=...)
    at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:435
nwjs#4  0x0000000000f7ecb3 in v8::internal::Debugger::CallCEventCallback (
    this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=...,
    client_data=0x0) at ../../v8/src/debug.cc:2953
nwjs#5  0x0000000000f7ebf9 in v8::internal::Debugger::CallEventCallback (
    this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=...,
    client_data=0x0) at ../../v8/src/debug.cc:2932
nwjs#6  0x0000000000f7eabd in v8::internal::Debugger::ProcessDebugEvent (
    this=0x7ffff7eec520, event=v8::Break, event_data=..., auto_continue=false)
    at ../../v8/src/debug.cc:2909
nwjs#7  0x0000000000f7e24d in v8::internal::Debugger::OnDebugBreak (
    this=0x7ffff7eec520, break_points_hit=..., auto_continue=false)
    at ../../v8/src/debug.cc:2750
nwjs#8  0x0000000000f7836f in v8::internal::Debug::Break (this=0x7ffff7eecc20,
    args=...) at ../../v8/src/debug.cc:992
nwjs#9  0x0000000000f787a8 in v8::internal::__RT_impl_Debug_Break (args=...,
    isolate=0x7ffff7e80020) at ../../v8/src/debug.cc:1062
nwjs#10 0x0000000000f78769 in v8::internal::Debug_Break (args_length=0,
    args_object=0x7fffffff8248, isolate=0x7ffff7e80020)
    at ../../v8/src/debug.cc:1061
jtg-gg pushed a commit to jtg-gg/blink that referenced this pull request Nov 14, 2014
@rogerwang
Properly find Frame from Node context
1f7dc28 
or debug callback can't get the listener.
Fix nwjs/nw.js#719

#0  WebCore::InspectorDebuggerAgent::didPause (this=0x7ffff7ee8800,
    scriptState=0x192e07eebb10, callFrames=..., exception=...)
    at ../../third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp:682
#1  0x0000000003665f7e in WebCore::ScriptDebugServer::breakProgram (
    this=0x7ffff7ee8260, executionState=..., exception=...)
    at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:425
nwjs#2  0x0000000003666ceb in WebCore::ScriptDebugServer::handleV8DebugEvent (
    this=0x7ffff7ee8260, eventDetails=...)
    at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:503
nwjs#3  0x0000000003666012 in WebCore::ScriptDebugServer::v8DebugEventCallback (
    eventDetails=...)
    at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:435
nwjs#4  0x0000000000f7ecb3 in v8::internal::Debugger::CallCEventCallback (
    this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=...,
    client_data=0x0) at ../../v8/src/debug.cc:2953
nwjs#5  0x0000000000f7ebf9 in v8::internal::Debugger::CallEventCallback (
    this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=...,
    client_data=0x0) at ../../v8/src/debug.cc:2932
nwjs#6  0x0000000000f7eabd in v8::internal::Debugger::ProcessDebugEvent (
    this=0x7ffff7eec520, event=v8::Break, event_data=..., auto_continue=false)
    at ../../v8/src/debug.cc:2909
nwjs#7  0x0000000000f7e24d in v8::internal::Debugger::OnDebugBreak (
    this=0x7ffff7eec520, break_points_hit=..., auto_continue=false)
    at ../../v8/src/debug.cc:2750
nwjs#8  0x0000000000f7836f in v8::internal::Debug::Break (this=0x7ffff7eecc20,
    args=...) at ../../v8/src/debug.cc:992
nwjs#9  0x0000000000f787a8 in v8::internal::__RT_impl_Debug_Break (args=...,
    isolate=0x7ffff7e80020) at ../../v8/src/debug.cc:1062
nwjs#10 0x0000000000f78769 in v8::internal::Debug_Break (args_length=0,
    args_object=0x7fffffff8248, isolate=0x7ffff7e80020)
    at ../../v8/src/debug.cc:1061
jtg-gg pushed a commit to jtg-gg/blink that referenced this pull request Nov 14, 2014
@rogerwang
Properly find Frame from Node context
ee752dc 
or debug callback can't get the listener.
Fix nwjs/nw.js#719

#0  WebCore::InspectorDebuggerAgent::didPause (this=0x7ffff7ee8800,
    scriptState=0x192e07eebb10, callFrames=..., exception=...)
    at ../../third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp:682
#1  0x0000000003665f7e in WebCore::ScriptDebugServer::breakProgram (
    this=0x7ffff7ee8260, executionState=..., exception=...)
    at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:425
nwjs#2  0x0000000003666ceb in WebCore::ScriptDebugServer::handleV8DebugEvent (
    this=0x7ffff7ee8260, eventDetails=...)
    at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:503
nwjs#3  0x0000000003666012 in WebCore::ScriptDebugServer::v8DebugEventCallback (
    eventDetails=...)
    at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:435
nwjs#4  0x0000000000f7ecb3 in v8::internal::Debugger::CallCEventCallback (
    this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=...,
    client_data=0x0) at ../../v8/src/debug.cc:2953
nwjs#5  0x0000000000f7ebf9 in v8::internal::Debugger::CallEventCallback (
    this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=...,
    client_data=0x0) at ../../v8/src/debug.cc:2932
nwjs#6  0x0000000000f7eabd in v8::internal::Debugger::ProcessDebugEvent (
    this=0x7ffff7eec520, event=v8::Break, event_data=..., auto_continue=false)
    at ../../v8/src/debug.cc:2909
nwjs#7  0x0000000000f7e24d in v8::internal::Debugger::OnDebugBreak (
    this=0x7ffff7eec520, break_points_hit=..., auto_continue=false)
    at ../../v8/src/debug.cc:2750
nwjs#8  0x0000000000f7836f in v8::internal::Debug::Break (this=0x7ffff7eecc20,
    args=...) at ../../v8/src/debug.cc:992
nwjs#9  0x0000000000f787a8 in v8::internal::__RT_impl_Debug_Break (args=...,
    isolate=0x7ffff7e80020) at ../../v8/src/debug.cc:1062
nwjs#10 0x0000000000f78769 in v8::internal::Debug_Break (args_length=0,
    args_object=0x7fffffff8248, isolate=0x7ffff7e80020)
    at ../../v8/src/debug.cc:1061
jtg-gg pushed a commit to jtg-gg/blink that referenced this pull request Nov 14, 2014
@rogerwang
Properly find Frame from Node context
6546c75 
or debug callback can't get the listener.
Fix nwjs/nw.js#719

#0  WebCore::InspectorDebuggerAgent::didPause (this=0x7ffff7ee8800,
    scriptState=0x192e07eebb10, callFrames=..., exception=...)
    at ../../third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp:682
#1  0x0000000003665f7e in WebCore::ScriptDebugServer::breakProgram (
    this=0x7ffff7ee8260, executionState=..., exception=...)
    at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:425
nwjs#2  0x0000000003666ceb in WebCore::ScriptDebugServer::handleV8DebugEvent (
    this=0x7ffff7ee8260, eventDetails=...)
    at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:503
nwjs#3  0x0000000003666012 in WebCore::ScriptDebugServer::v8DebugEventCallback (
    eventDetails=...)
    at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:435
nwjs#4  0x0000000000f7ecb3 in v8::internal::Debugger::CallCEventCallback (
    this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=...,
    client_data=0x0) at ../../v8/src/debug.cc:2953
nwjs#5  0x0000000000f7ebf9 in v8::internal::Debugger::CallEventCallback (
    this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=...,
    client_data=0x0) at ../../v8/src/debug.cc:2932
nwjs#6  0x0000000000f7eabd in v8::internal::Debugger::ProcessDebugEvent (
    this=0x7ffff7eec520, event=v8::Break, event_data=..., auto_continue=false)
    at ../../v8/src/debug.cc:2909
nwjs#7  0x0000000000f7e24d in v8::internal::Debugger::OnDebugBreak (
    this=0x7ffff7eec520, break_points_hit=..., auto_continue=false)
    at ../../v8/src/debug.cc:2750
nwjs#8  0x0000000000f7836f in v8::internal::Debug::Break (this=0x7ffff7eecc20,
    args=...) at ../../v8/src/debug.cc:992
nwjs#9  0x0000000000f787a8 in v8::internal::__RT_impl_Debug_Break (args=...,
    isolate=0x7ffff7e80020) at ../../v8/src/debug.cc:1062
nwjs#10 0x0000000000f78769 in v8::internal::Debug_Break (args_length=0,
    args_object=0x7fffffff8248, isolate=0x7ffff7e80020)
    at ../../v8/src/debug.cc:1061
scheib pushed a commit to scheib/blink that referenced this pull request Jan 27, 2015
@mfalken
Revert of Change EME SessionType to include both types of persistent …
9789caf 
…sessions. (patchset nwjs#4 id:60001 of https://codereview.chromium.org/831403003/)

Reason for revert:
This likely caused browser_test failures on the Linux ChromiumOS Tests (dbg) bot:

ECKUnprefixedEncryptedMediaTest.LoadLoadableSession
ECKUnprefixedEncryptedMediaTest.LoadUnknownSession

Build:
http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/4887

Excerpt from log:
[30209:30209:0106/212709:INFO:CONSOLE(147)] "FAIL: TypeError Failed to execute 'createSession' on 'MediaKeys': parameter 1 ('persistent') is not a valid enum value.", source: http://127.0.0.1:58033/files/eme_player_js/utils.js (147)

Original issue's description:
> Change EME SessionType to include both types of persistent sessions.
> 
> SessionType can now be "temporary", "persistent-license", or
> "persistent-release-message". "persistent-release-message" is not yet
> supported on the Chromium side, so using it will fail.
> 
> BUG=224786
> TEST=existing EME tests pass
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187944

TBR=ddorwin@chromium.org,sandersd@chromium.org,jrummell@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=224786

Review URL: https://codereview.chromium.org/838443008

git-svn-id: svn://svn.chromium.org/blink/trunk@187952 bbb929c8-8fbe-4397-9dbb-9b2b20218538
scheib pushed a commit to scheib/blink that referenced this pull request Jan 27, 2015
@zhenyao
Revert of Move the user agent styles sheets to blink_resources.grd (P…
a4de232 
…art 3) (patchset nwjs#4 id:60001 of https://codereview.chromium.org/573553002/)

Reason for revert:
This caused 
BatteryMonitorIntegrationTest.DefaultValues
BatteryMonitorIntegrationTest.EventListener BatteryMonitorIntegrationTest.ResolvePromise

to time out on android debug bots.

One example: http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/23812

C 1558.589s Main  Detailed Logs
C 1558.589s Main  ********************************************************************************
C 1558.590s Main  [TIMEOUT] BatteryMonitorIntegrationTest.DefaultValues:
C 1558.590s Main  [WARNING:dns_config_service_posix.cc(293)] Failed to read DnsConfig.
C 1558.590s Main  [ERROR:unix_domain_server_socket_posix.cc(106)] Not implemented reached in virtual int net::UnixDomainServerSocket::GetLocalAddress(net::IPEndPoint*) const
C 1558.590s Main  [WARNING:proxy_service.cc(899)] PAC support disabled because there is no system implementation
C 1558.590s Main  
C 1558.590s Main  [TIMEOUT] BatteryMonitorIntegrationTest.EventListener:
C 1558.590s Main  [WARNING:dns_config_service_posix.cc(293)] Failed to read DnsConfig.
C 1558.590s Main  [ERROR:unix_domain_server_socket_posix.cc(106)] Not implemented reached in virtual int net::UnixDomainServerSocket::GetLocalAddress(net::IPEndPoint*) const
C 1558.590s Main  [WARNING:proxy_service.cc(899)] PAC support disabled because there is no system implementation
C 1558.590s Main  [WARNING:channel.cc(136)] WriteMessage() while shutting down
C 1558.590s Main  [WARNING:channel.cc(553)] Failed to send message to remove remote endpoint (local ID 3, remote ID 2147483649)
C 1558.590s Main  [WARNING:channel.cc(320)] RawChannel write error
C 1558.590s Main  
C 1558.591s Main  [TIMEOUT] BatteryMonitorIntegrationTest.ResolvePromise:
C 1558.591s Main  [WARNING:dns_config_service_posix.cc(293)] Failed to read DnsConfig.
C 1558.591s Main  [ERROR:unix_domain_server_socket_posix.cc(106)] Not implemented reached in virtual int net::UnixDomainServerSocket::GetLocalAddress(net::IPEndPoint*) const
C 1558.591s Main  [WARNING:proxy_service.cc(899)] PAC support disabled because there is no system implementation
C 1558.591s Main  [WARNING:channel.cc(136)] WriteMessage() while shutting down
C 1558.591s Main  [WARNING:channel.cc(136)] WriteMessage() while shutting down

Original issue's description:
> Reland Move the user agent styles sheets to blink_resources.grd (Part 3)
> 
> Blink should make use of blink_resources.grd for the inline resources of user agent stylesheets.
> This removes the dependency upon using make-file-arrays.py which embeds these resources as strings. 
> 
> Also the .rodata section of libblink_web (in component build mode) is reduced by ~33kb.
> 
> Part 1: https://codereview.chromium.org/436843004/
> Part 2: https://codereview.chromium.org/422023008
> 
> The chromium dependent patches [1] and [2] have already landed.
> 
> [1] https://codereview.chromium.org/818563003
> [2] https://codereview.chromium.org/819573002
> 
> BUG=312586
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188383

TBR=jochen@chromium.org,dtapuska@chromium.org,jamesr@chromium.org,vivekg@chromium.org,vivek.vg@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=312586

Review URL: https://codereview.chromium.org/852033002

git-svn-id: svn://svn.chromium.org/blink/trunk@188404 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang pushed a commit that referenced this pull request Jan 28, 2015
Revert of Don't display pie chart when event is not a parent. (patchset
4c5cf0a 
#4 id:60001 of https://codereview.chromium.org/718283002/)

Reason for revert:
Breaks DevTools Closure compilation

Original issue's description:
> Don't display pie chart when event is not a parent.
> 
> Driveby: widen timeline details left column to fit text like "Recalculation was forced" or "first layout invalidation"
> 
> BUG=421295
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186254

TBR=yurys@chromium.org,pdr@chromium.org,pfeldman@chromium.org,paulirish@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=421295

Review URL: https://codereview.chromium.org/769183002

git-svn-id: svn://svn.chromium.org/blink/trunk@186287 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang pushed a commit that referenced this pull request Jan 28, 2015
@ishermandom
Revert of Implement unset value handling (patchset #4 id:80001 of htt…
cfe43ca 
…ps://codereview.chromium.org/775153002/)

Reason for revert:
This broke the Linux Oilpan Builder.

Logs: http://build.chromium.org/p/chromium.perf/builders/Linux%20Oilpan%20Builder/builds/13454/steps/compile/logs/stdio#error1

BUG=439604

Original issue's description:
> Implement unset value handling
> 
> This patch accepts unset as a valid CSS value and creates
> a CSSUnsetValue object for it. Then when resolving it the
> rules stated in below link are implemented:
> 
> http://dev.w3.org/csswg/css-cascade/#valuedef-unset
> 
> Add a test for the new behavior.
> 
> BUG=431689
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186604

TBR=timloh@chromium.org,rob.buis@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=431689

Review URL: https://codereview.chromium.org/782853002

git-svn-id: svn://svn.chromium.org/blink/trunk@186627 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang pushed a commit that referenced this pull request Jan 28, 2015
@ishermandom
Revert of Revert of Implement unset value handling (patchset #1 id:1 of
3537c9a 
https://codereview.chromium.org/782853002/)

Reason for revert:
A build fix has landed, so the revert is no longer necessary.

Original issue's description:
> Revert of Implement unset value handling (patchset #4 id:80001 of https://codereview.chromium.org/775153002/)
> 
> Reason for revert:
> This broke the Linux Oilpan Builder.
> 
> Logs: http://build.chromium.org/p/chromium.perf/builders/Linux%20Oilpan%20Builder/builds/13454/steps/compile/logs/stdio#error1
> 
> BUG=439604
> 
> Original issue's description:
> > Implement unset value handling
> > 
> > This patch accepts unset as a valid CSS value and creates
> > a CSSUnsetValue object for it. Then when resolving it the
> > rules stated in below link are implemented:
> > 
> > http://dev.w3.org/csswg/css-cascade/#valuedef-unset
> > 
> > Add a test for the new behavior.
> > 
> > BUG=431689
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186604
> 
> TBR=timloh@chromium.org,rob.buis@samsung.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=431689
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186627

TBR=timloh@chromium.org,rob.buis@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=439604

Review URL: https://codereview.chromium.org/773483003

git-svn-id: svn://svn.chromium.org/blink/trunk@186637 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang pushed a commit that referenced this pull request Jan 28, 2015
@jianli-chromium
Revert of Add plumbing for content to notify RemoteFrame about loadin…
fcee2ce 
…g status. (patchset #4 id:60001 of https://codereview.chromium.org/801073002/)

Reason for revert:
It might cause the failure to test TaskManagerOOPIFBrowserTest.KillSubframe/1.

http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/41321
http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/7513
http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/11212

Original issue's description:
> Add plumbing for content to notify RemoteFrame about loading status.
> 
> BUG=436250
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187287

TBR=japhet@chromium.org,dcheng@chromium.org,nasko@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=436250

Review URL: https://codereview.chromium.org/807623005

git-svn-id: svn://svn.chromium.org/blink/trunk@187297 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang pushed a commit that referenced this pull request Jan 28, 2015
@quisquous
Revert of Oilpan: Remove redundant LifecycleObserver from DOMTimer::f…
88a158a 
…ired (patchset #1 id:1 of https://codereview.chromium.org/823773003/)

Reason for revert:
Makes ASAN bots red.

STDERR: ==8== WARNING: MemorySanitizer: use-of-uninitialized-value
STDERR:     #0 0x7f4ebe7c540e in blink::DOMTimer::fired() third_party/WebKit/Source/core/frame/DOMTimer.cpp:168:9
STDERR:     #1 0x7f4ec5bc8b4c in blink::ThreadTimers::sharedTimerFiredInternal() third_party/WebKit/Source/platform/ThreadTimers.cpp:137:9
STDERR:     #2 0x7f4ec5bc7fef in blink::ThreadTimers::sharedTimerFired() third_party/WebKit/Source/platform/ThreadTimers.cpp:107:5
STDERR:     #3 0x7f4ec451bae7 in Run base/callback.h:396:12
STDERR:     #4 0x7f4ec451bae7 in base::Timer::RunScheduledTask() base/timer/timer.cc:211:0

Original issue's description:
> Oilpan: Remove redundant LifecycleObserver from DOMTimer::fired
> 
> It is redundant to create a LifecycleObserver in DOMTimer::fired, because DOMTimer is an ActiveDOMObject and thus it can just peek executionContext() to know whether its associated ExecutionContext is already gone or not.
> 
> BUG=340522
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187649

NOTRY=true
TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com,haraken@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/821313002

git-svn-id: svn://svn.chromium.org/blink/trunk@187668 bbb929c8-8fbe-4397-9dbb-9b2b20218538
@rogerwang rogerwang closed this Mar 6, 2015
jtg-gg pushed a commit to jtg-gg/blink that referenced this pull request Jul 31, 2015
@mfalken
Revert of Remove ResourceFetcher's access to a real FetchContext at f…
8310e5c 
…rame detach time (patchset nwjs#4 id:60001 of https://codereview.chromium.org/1035803002/)

Reason for revert:
Causes an assert failure on imported/web-platform-tests/custom-elements/creating-and-passing-registries/share-registry-import-document.html

ASSERTION FAILED: m_thread == currentThread()
../../third_party/WebKit/Source/platform/Timer.h(160) : bool blink::TimerBase::isActive() const
1   0x7f421ebb9357
2   0x7f422003e6bb
3   0x7f422003f214
4   0x7f4229e9ae37 blink::ThreadTimers::sharedTimerFiredInternal()
5   0x7f4229e9aa65 blink::ThreadTimers::sharedTimerFired()

Example failure: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20(dbg)/builds/368

I verified locally that reverting fixes the test.

Original issue's description:
> Remove ResourceFetcher's access to a real FetchContext at frame detach time
> 
> This allows us to remove a whole bunch of frame() null-checks in FrameFetchContext.
> 
> BUG=458222
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193208

TBR=haraken@chromium.org,mkwst@chromium.org,sigbjornf@opera.com,japhet@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=458222

Review URL: https://codereview.chromium.org/1063913002

git-svn-id: svn://svn.chromium.org/blink/trunk@193231 bbb929c8-8fbe-4397-9dbb-9b2b20218538
jtg-gg pushed a commit to jtg-gg/blink that referenced this pull request Jul 31, 2015
@RByers
Revert of Schedule cursor update when DOM updates layout. (patchset n…
b5012e8 
…wjs#4 id:60001 of https://codereview.chromium.org/915543003/)

Reason for revert:
Exposed mouse cursor flicker regression: http://crbug.com/468641 (due to a pre-existing bug - http://crbug.com/482971).

Original issue's description:
> Schedule cursor update when DOM updates layout.
> 
> BUG=26723
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190676

TBR=zhengw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=26723

Review URL: https://codereview.chromium.org/1120653002

git-svn-id: svn://svn.chromium.org/blink/trunk@194743 bbb929c8-8fbe-4397-9dbb-9b2b20218538
jtg-gg pushed a commit to jtg-gg/blink that referenced this pull request Jul 31, 2015
Revert of Put LayoutAnalyzer back behind disabled-by-default-blink.de…
b9beb01 
…bug.layout. (patchset nwjs#4 id:60001 of https://codereview.chromium.org/1120833003/)

Reason for revert:
crbug.com/483390  Looks like this change may have caused the test on that bug to fail on all bots.  A speculative revert might help resolve that.  Will roll back in otherwise.

Original issue's description:
> Put LayoutAnalyzer back behind disabled-by-default-blink.debug.layout.
> 
> Another CL will remove the UMA.
> 
> When the deep reports category is ready, this will move over to that.
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194781

TBR=esprehn@chromium.org,benjhayden@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1122453002

git-svn-id: svn://svn.chromium.org/blink/trunk@194796 bbb929c8-8fbe-4397-9dbb-9b2b20218538
jtg-gg pushed a commit to jtg-gg/blink that referenced this pull request Jul 31, 2015
@arv
Revert of Make Window.prototype.toString return [object Window] at al…
97bf898 
…l times. (patchset nwjs#4 id:60001 of https://codereview.chromium.org/1138583002/)

Reason for revert:
Going to disable --harmony-tostring until our bindings have been updated.

Original issue's description:
> Make Window.prototype.toString return [object Window] at all times.
>
> The old code was incorrectly falling back to
> Object.prototype.toString.call which does not work as expected without
> full support for @@toSringTag
>
> BUG=239915
> R=adamk, jsbell
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195193

TBR=adamk@chromium.org,jsbell@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=239915

Review URL: https://codereview.chromium.org/1163943002

(cherry picked from commit 4958fd9)

Review URL: https://codereview.chromium.org/1182643002.

git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2403@196974 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@libm @rogerwang