Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified ggmaps section #250

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Mrugankakarte
Copy link

I have added examples for using stamenmaps with ggmaps.

@jtr13
Copy link
Owner

jtr13 commented Oct 23, 2019

This looks great! As soon as I get a chance I will test the code. In the meantime, please add ggmap to the imports section of the DESCRIPTION file on your branch. Also, is it possible to read the uscities.csv from a URL? We had a problem with the repo size growing quickly so would rather not add large data files.

@Mrugankakarte
Copy link
Author

I have added the ggmap to DESCRIPTION file. Regarding the data, unfortunately I cannot read it directly from url, but I have removed the csv file and replaced it with the zipped version which is 900Kb instead of 5Mb. I am directly read the csv file using unz().

@jtr13
Copy link
Owner

jtr13 commented Oct 28, 2019

Let's find a time to discuss perhaps after class one day. I like the use of longitude and latitude for the military bases, but I find it problematic to plot density at points rather than areas. I'm not convinced the graphs are really showing density.

@Mrugankakarte
Copy link
Author

As discussed I have changed the population density to spread of counties. Kindly let me know if any changes are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants