Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse all deflocalkeys variants regardless of target os #540

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

rszyma
Copy link
Contributor

@rszyma rszyma commented Aug 22, 2023

Describe your changes. Use imperative present tense.

Parse all deflocalkeys variants for errors regardless of target OS, but apply only the one based on target OS.

This PR fixes rszyma/vscode-kanata#1

Checklist

  • Add documentation to docs/config.adoc
    • N/A
  • Add example to cfg_samples/kanata.kbd
    • N/A
  • Update error messages
    • Yes
  • Added tests, or did manual testing
    • Yes (manual testing)

@jtroo jtroo merged commit 5dc3296 into jtroo:main Aug 23, 2023
3 checks passed
@rszyma rszyma deleted the deflocalkeys-wasm-fix branch August 23, 2023 03:48
@rszyma rszyma mentioned this pull request Aug 26, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: syntax check for deflocalkeys-wintercept and deflocalkeys-win is not working
2 participants