Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: syntax check for deflocalkeys-wintercept and deflocalkeys-win is not working #1

Closed
rszyma opened this issue Aug 6, 2023 · 1 comment · Fixed by jtroo/kanata#540
Closed

Bug: syntax check for deflocalkeys-wintercept and deflocalkeys-win is not working #1

rszyma opened this issue Aug 6, 2023 · 1 comment · Fixed by jtroo/kanata#540
Labels
bug Something isn't working

Comments

@rszyma
Copy link
Owner

rszyma commented Aug 6, 2023 •
edited
Loading

Because of the fact that this project uses kanata-parser which has only experimental support for wasm, out of all deflocalkeys-* variants only deflocalkeys-linux is syntax-checked.

To fix this, a change in kanata-parser is required, so all deflocalkeys-* variants are checked for syntax regardless of target OS.
@rszyma rszyma added the bug Something isn't working label Aug 6, 2023
@rszyma rszyma mentioned this issue Aug 22, 2023
Merged
4 tasks
jtroo pushed a commit to jtroo/kanata that referenced this issue Aug 23, 2023
@rszyma
refactor: parse all deflocalkeys variants regardless of target os (#540)
5dc3296 
Parse all `deflocalkeys` variants for errors regardless of target OS,
but apply only the one based on target OS.

This PR fixes rszyma/vscode-kanata#1 

## Checklist

- Add documentation to docs/config.adoc
  - [x] N/A 
- Add example to cfg_samples/kanata.kbd
  - [x] N/A
- Update error messages
  - [x] Yes
- Added tests, or did manual testing
  - [x] Yes (manual testing)
@rszyma
Copy link
Owner Author

rszyma commented Aug 23, 2023

fix merged in kanata/main

@rszyma rszyma closed this as completed Aug 23, 2023
rszyma added a commit that referenced this issue Aug 23, 2023
@rszyma
Update kanata to 5dc3296. Fixes (#1)
e13c5e7
@rszyma rszyma mentioned this issue Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

parse all deflocalkeys variants regardless of target os rszyma/kanata
1 participant
@rszyma