Use evdev to create and write device #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @jian-lin, let me know what you think |
jian-lin
reviewed
Jul 23, 2022
| .into_iter() | ||
| .for_each(|ev| self.events.push_back(ev)); | ||
| } | ||
| Ok(self.events.pop_front().expect("not empty")) |
There was a problem hiding this comment.
Suggested change
| Ok(self.events.pop_front().expect("not empty")) | |
| Ok(self.events.pop_front().expect("event queue is empty")) |
Usually, this message tells us why it fails.
The evdev crate is added and these dependencies are dropped: - libc - uinput-sys - evdev-rs Replace uinput-sys with evdev because evdev is a wrapper library for evdev devices that provides interfaces to create uinput devices and send events. Using evdev is less error-prone than accessing uinput directly, and should be considered for new software[1]. evdev is also needed to create a symlink in /dev/input/by-id/ libc is dropped since its struct definitions are no longer required. evdev-rs is replaced by evdev so that the system library libevdev is no longer a dependency. [1]: https://www.kernel.org/doc/html/latest/input/uinput.html
|
Sorry, I just find that I have filled a feature request emberian/evdev#70. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The evdev crate is added and these dependencies are dropped:
Replace uinput-sys with evdev because evdev is a wrapper library for
evdev devices that provides interfaces to create uinput devices and send
events. Using evdev is less error-prone than accessing uinput directly,
and should be considered for new software1. evdev is also needed to
create a symlink in /dev/input/by-id/
libc is dropped since its struct definitions are no longer required.
evdev-rs is replaced by evdev so that the system library libevdev is no
longer a dependency.