Feature/Reflection extractors #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need a new name to import it with no conflicts
ahmedmeheinastudocu
previously approved these changes
Jul 29, 2022
sunchayn
reviewed
Aug 1, 2022
| use ReflectionClass; | ||
| use ReflectionException; | ||
|
|
||
| class ReflectionClassExtractor implements Extractor |
There was a problem hiding this comment.
what do you think about having a different concept, that we could call Transformers. Because what it does is transform a provided class into its Reflection counterpart. It does not extract anything yet 🤔
There was a problem hiding this comment.
I was also annoyed at the "extractor" method. I'll message you tomorrow about it, but I was thinking to simply call it pipe, and then people are free to do whatever 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.