Develop #2
Merged
Develop #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges == Check Interface == Instead of having one `run()` method, now we separated the getMatches with processMatch methods. In a way, it's similar to PHPStan's Rule interface. getNodeTypes and processNodes. The processMatch method returns an array of ViolationBuilder instances. If it returns an empty array, the match will not be counted as a violation. The ViolationBuilder now changed. The identifier and file are not required. If they are not present, they will be added automatically by the CheckRunner. If they are present, they won't be changed. == ViolationBuilder == The explanation is changed for `message` now. And the `build` method should not be called from the processMatch. It will be called from the CheckRunner, with the fallback identifier as the check name, and the fallback file as the match found initially.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.