Skip to content

Conversation

nshaphan
Copy link
Contributor

Fixes #19

@juanjoDiaz
Copy link
Owner

Hi @nshaphan ,

Good catch!

However, pushLine is an internal method.
The correct method to use here is write instead of push.

@nshaphan nshaphan changed the title docs: use json2csvParser.pushLine instead of json2csvParser.push docs: use json2csvParser.pushLine instead of json2csvParser.write Feb 23, 2023
@nshaphan
Copy link
Contributor Author

Hi @nshaphan ,

Good catch!

However, pushLine is an internal method. The correct method to use here is write instead of push.

I have changed from pushLine to use write @juanjoDiaz

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4250452711

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.888%

Totals Coverage Status
Change from base Build 4026331155: 0.0%
Covered Lines: 1408
Relevant Lines: 1432

💛 - Coveralls

@juanjoDiaz juanjoDiaz merged commit c9cbda7 into juanjoDiaz:main Mar 8, 2023
@coveralls
Copy link

coveralls commented Jul 16, 2024

Pull Request Test Coverage Report for Build 4250452711

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.888%

Totals Coverage Status
Change from base Build 4026331155: 0.0%
Covered Lines: 1408
Relevant Lines: 1432

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data selection docs use parser.push instead of parser.write
3 participants