Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyroscope client and godeltaprof to support Go 1.22 #4340

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Bump pyroscope client and godeltaprof to support Go 1.22 #4340

merged 3 commits into from
Jan 16, 2024

Conversation

stefanb
Copy link
Contributor

@stefanb stefanb commented Jan 14, 2024

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3cd0726) 55.87% compared to head (5db45da) 55.88%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4340      +/-   ##
==========================================
+ Coverage   55.87%   55.88%   +0.01%     
==========================================
  Files         154      154              
  Lines       39899    39899              
==========================================
+ Hits        22295    22299       +4     
- Misses      15091    15094       +3     
+ Partials     2513     2506       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanb
Copy link
Contributor Author

stefanb commented Jan 15, 2024

Because build fails on ancient Go 1.18 with error from build log:

# github.com/klauspost/compress/zstd
Error: ../../../go/pkg/mod/github.com/klauspost/compress@v1.17.3/zstd/dict.go:479:32: binary.LittleEndian.AppendUint32 undefined (type binary.littleEndian has no field or method AppendUint32)
Error: ../../../go/pkg/mod/github.com/klauspost/compress@v1.17.3/zstd/dict.go:490:32: binary.LittleEndian.AppendUint32 undefined (type binary.littleEndian has no field or method AppendUint32)
Error: ../../../go/pkg/mod/github.com/klauspost/compress@v1.17.3/zstd/dict.go:491:32: binary.LittleEndian.AppendUint32 undefined (type binary.littleEndian has no field or method AppendUint32)
Error: ../../../go/pkg/mod/github.com/klauspost/compress@v1.17.3/zstd/dict.go:492:32: binary.LittleEndian.AppendUint32 undefined (type binary.littleEndian has no field or method AppendUint32)
note: module requires Go 1.19

...I have removed bumped min Go version from 1.18 to 1.19 and included 1.22rc1 in the build matrix in 62486a7.

go.mod Outdated Show resolved Hide resolved
@zhijian-pro
Copy link
Contributor

We are in the process of upgrading the go version to 1.20. This pr can wait a little bit.

@stefanb
Copy link
Contributor Author

stefanb commented Jan 16, 2024

Tnx, will wait for #4334 & #4326, then rebase again and resolve any conflicts.

stefanb and others added 3 commits January 16, 2024 07:25
* github.com/pyroscope-io/client was moved to github.com/grafana/pyroscope-go
* Go 1.22 support was added in godeltaprof
 0.1.6 via grafana/pyroscope-go#55

Fixes #4339
Co-Authored-By: zhijian <jiaxingduan@gmail.com>
@stefanb
Copy link
Contributor Author

stefanb commented Jan 16, 2024

Rebased and resolved all conflicts with #4334 regarding minimal required go version.

@zhijian-pro
Copy link
Contributor

LGTM!

@SandyXSD SandyXSD merged commit 1616431 into juicedata:main Jan 16, 2024
26 checks passed
@stefanb stefanb deleted the go1.22 branch January 16, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Go 1.22
4 participants