-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pyroscope client and godeltaprof to support Go 1.22 #4340
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4340 +/- ##
==========================================
+ Coverage 55.87% 55.88% +0.01%
==========================================
Files 154 154
Lines 39899 39899
==========================================
+ Hits 22295 22299 +4
- Misses 15091 15094 +3
+ Partials 2513 2506 -7 ☔ View full report in Codecov by Sentry. |
Because build fails on ancient Go 1.18 with error from build log:
...I have removed bumped min Go version from 1.18 to 1.19 and included 1.22rc1 in the build matrix in 62486a7. |
We are in the process of upgrading the go version to 1.20. This pr can wait a little bit. |
* github.com/pyroscope-io/client was moved to github.com/grafana/pyroscope-go * Go 1.22 support was added in godeltaprof 0.1.6 via grafana/pyroscope-go#55 Fixes #4339
Co-Authored-By: zhijian <jiaxingduan@gmail.com>
Rebased and resolved all conflicts with #4334 regarding minimal required go version. |
LGTM! |
github.com/pyroscope-io/client
was moved togithub.com/grafana/pyroscope-go
, see redirect of https://github.com/pyroscope-io/clientgodeltaprof
0.1.6 via chore: relax internals stub build tag to golang 1.22 grafana/pyroscope-go#55