Skip to content

Conversation

Daumas-hugo
Copy link

Description

When launching the demo on flutter Android you couldn't change the rotation speed
because it was Parsed in such a way that the "0.0" format throwed a
Parsing Error

Now it doesn't 🤖

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

When launching the demo on flutter Android you couldn't change the rotation speed
because it was Parsed in such a way that the "0.0" format throwed a
Parsing Error
Copy link
Author

@Daumas-hugo Daumas-hugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When launching the demo on flutter Android you couldn't change the rotation speed
because it was Parsed in such a way that the "0.0" format throwed a
Parsing Error

@timbotimbo
Copy link
Collaborator

I can reproduce the bug with a dutch localization ( , decimal separator) while it is not present in english (. decimal separator).
I've tested the fix and can confirm it works.

@timbotimbo timbotimbo merged commit d68f880 into juicycleff:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants