Disable bitcode for Xcode 14. #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, it's currently under testing locally and on jenkins CI in our project. And here is some nicely written background for bitcode: https://stackoverflow.com/a/73219854/1123085 |
|
Turning off bitcode for unity project helped building the app on our CI. Since it's deprecated and not used, I would definitely merge it. |
nenenkosi
approved these changes
Feb 9, 2023
pawlowskim
approved these changes
Feb 10, 2023
timbotimbo
requested review from
juicycleff
and removed request for
juicycleff
RoyalCoder88
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Xcode 14 deprecates bitcode, and since today Flutter 3.7 has dropped support for bitcode.
We should disable this setting in the iOS export.
Anyone that still needs it for older projects can simply turn it on again or use an older unitypackage.
Type of Change