Yum + LSB fix making package installation on CentOS possible #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fetch module: - prevents CentOS deployments from using Ubuntu specific functions in fetch/__init__.py - removed dependency on yum.py from Python2 in fetch/centos.py In host factory: - cmp_pgrevno() can now be run with Python 3 - does not require root to run anymore - replaced yum with rpm -q using subprocess (faster) - no logic changed
init_is_systemd() was looking for the non-existing DISTRIB_CODENAME in /etc/os-release via the lsb_release() function, which generates a KeyError on CentOS. The distribution info on CentOS is in /etc/os-release since version 7, which is also when systemd was introduced. If this file is not present, we can safely assume CentOS 6 or older.
|
LGTM |
Thanks @ajkavanagh, I think Rick Harding will bring this up with you later today, just a heads up. |
|
Hey guys, how is this coming along? |
I think we were looking for the branch to get updated so it was up to date with latest trunk? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Python 3, package installation with fetch in charmhelpers does not work since the Python module "yum" is only available for Python2. Simple tasks like checking if packages are installed can easily be performed by RPM instead.
Furthermore, package installations on CentOS were previously carried out with apt (which fails), this has been fixed.
LSB: The variable DISTRIB_CODENAME used for checking if we're using a systemd system is not available in /etc/os-release on CentOS, which throws a KeyError. This information is available in /etc/os-release from CentOS/RHEL 7 and above, which also use systemd.