This repository has been archived by the owner on May 12, 2021. It is now read-only.
Fixed bug 1321345 #335
Merged
Fixed bug 1321345 #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA ok, code looks fine. 👍 |
|
Thanks for the review and qa! |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
|
Test PASSed. |
jujugui
added a commit
that referenced
this pull request
May 20, 2014
When charm urls contained a hyphenated name and a charm version number the package name was not parsed correctly when creating a new model. #### To QA - Use the il and mv flags (This bug only presented itself using these flags). - Search for the `juju-gui`. - Drag and drop it onto the canvas. - Click the service icon to open the inspector. - Close the inspector - The service token should still read `juju-gui`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When charm urls contained a hyphenated name and a charm version number the package name was not parsed correctly when creating a new model.
To QA
juju-gui.juju-gui